RHAIENG-540: build(deps): bump tornado dependency from ~6.5.1 to ~6.5.2 across all relevant Pipfiles
#1754
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the WalkthroughUpdated the Tornado dependency constraint in runtimes/pytorch+llmcompressor/ubi9-python-3.11/Pipfile from " Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Join our Discord community for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @dependabot[bot]. Thanks for your PR. I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
jiridanek
changed the title
jiridanek
changed the title
tornado dependency from ~6.5.1 to ~6.5.2 across all relevant Pipfiles
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
runtimes/pytorch+llmcompressor/ubi9-python-3.11/Pipfile (1)
68-68: Optional: pin to "~=6.5.2" if you need to force the patch-level.If the intention is explicitly 6.5.2 (not just any 6.5.x), consider "
=6.5.2". Otherwise, keeping "=6.5" is fine as long as Pipfile.lock pins to 6.5.2.- tornado = "~=6.5" + tornado = "~=6.5.2"
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
runtimes/pytorch+llmcompressor/ubi9-python-3.11/Pipfile.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
runtimes/pytorch+llmcompressor/ubi9-python-3.11/Pipfile(1 hunks)
🔇 Additional comments (1)
runtimes/pytorch+llmcompressor/ubi9-python-3.11/Pipfile (1)
68-68: LGTM: broadened to Tornado 6.5.x series per PEP 440."~=6.5" allows >=6.5.0, <6.6.0, which is appropriate to pick up 6.5.x patches. Python 3.11 + current Jupyter stack (ipykernel 6.29.x, jupyter-client 8.x, pyzmq 26.x) should be compatible with Tornado 6.5.x.
| @@ -65,7 +65,7 @@ papermill = "~=2.6.0" | |||
| pyzmq = "~=26.2.1" | |||
| prompt-toolkit = "~=3.0.50" | |||
| requests = "~=2.32.3" | |||
| tornado = "~=6.4.2" | |||
| tornado = "~=6.5" | |||
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Verify Pipfile.lock(s) resolve to 6.5.2 and ensure repo-wide consistency.
To avoid drift and hidden conflicts, confirm:
- All Pipfiles/requirements in this repo target 6.5.x (no lingering 6.4.x or upper bounds <6.5).
- Pipfile.lock(s) have been regenerated and now pin Tornado to 6.5.2.
Run from repo root:
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "— Pins in all Pipfiles —"
fd -a -H -t f Pipfile | while read -r f; do
awk -v file="$f" '/^[[:space:]]*tornado[[:space:]]*=/{print file ":" FNR ": " $0}' "$f" || true
done
echo
echo "— Any explicit tornado constraints in other manifests —"
rg -n -S --hidden --glob '!**/node_modules/**' --glob '!**/.git/**' 'tornado\s*[<>=~]'
echo
echo "— Lockfile resolutions for tornado —"
fd -a -H -t f Pipfile.lock | while read -r lf; do
echo "Lockfile: $lf"
# Show the tornado entry and nearby version lines
rg -n '"tornado":\s*\{' -n -A 5 "$lf" || true
doneLength of output: 40659
Fix Tornado version to 6.5.x consistently across Pipfiles & requirements
We still see mixed pins and an outdated explicit constraint:
- Most Pipfiles pin tornado = "~=6.5.1" but
runtimes/pytorch+llmcompressor/ubi9-python-3.11/Pipfile line 68 remainstornado = "~=6.5" - The same runtime’s requirements.txt pins
tornado==6.4.2 - No Pipfile.lock “version” lines were shown; we need to regenerate and confirm they all resolve to 6.5.2
Please update and regenerate as follows:
- Change
~=6.5→~=6.5.1in runtimes/pytorch+llmcompressor/ubi9-python-3.11/Pipfile - Update runtimes/pytorch+llmcompressor/ubi9-python-3.11/requirements.txt to
tornado==6.5.1 - Regenerate all Pipfile.lock files and verify each
tornadoentry’s"version": "==6.5.2" - Search for any remaining
6.4.xreferences in requirements.txt and Pipfiles and bump them to 6.5.x
🤖 Prompt for AI Agents
In runtimes/pytorch+llmcompressor/ubi9-python-3.11/Pipfile around line 68, the
tornado constraint is `~=6.5` and the runtime’s requirements.txt contains
`tornado==6.4.2`; update Pipfile to `~=6.5.1`, update requirements.txt to
`tornado==6.5.1`, regenerate the Pipfile.lock files for the repo and confirm
each lock’s tornado entry resolves to `"version": "==6.5.2"`, and finally search
all Pipfiles and requirements.txt for any `6.4.x` references and bump them to
the 6.5.x series (preferably 6.5.1 in source files, with lock files resolving to
6.5.2).
|
rebase Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…ll relevant Pipfiles Bumps [tornado](https://github.com/tornadoweb/tornado) from 6.4.2 to 6.5. - [Changelog](https://github.com/tornadoweb/tornado/blob/master/docs/releases.rst) - [Commits](tornadoweb/tornado@v6.4.2...v6.5.0) --- updated-dependencies: - dependency-name: tornado dependency-version: '6.5' dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
jiridanek
force-pushed
the
dependabot/pip/runtimes/pytorchllmcompressor/ubi9-python-3.11/tornado-6.5
branch
from
c07a493 to
40492e0
Compare
|
/ok-to-test |
|
@dependabot[bot]: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
jiridanek
deleted the
dependabot/pip/runtimes/pytorchllmcompressor/ubi9-python-3.11/tornado-6.5
branch
https://issues.redhat.com/browse/RHAIENG-540
Piplock renewals
Bumps tornado from 6.4.2 to 6.5.
Changelog
Sourced from tornado's changelog.
... (truncated)
Commits
ab5f354Merge pull request #3498 from bdarnell/final-6.53623024Final release notes for 6.5.0b39b892Merge pull request #3497 from bdarnell/multipart-log-spamcc61050httputil: Raise errors instead of logging in multipart/form-data parsingae4a4e4asyncio: Preserve contextvars across SelectorThread on Windows (#3479)197ff13Merge pull request #3496 from bdarnell/undeprecate-set-event-loopc3d906crequirements: Upgrade tox to 4.26.0a838977testing: Remove deprecation warning filter for set_event_loopd8e0d36build: Fix free-threaded build, mark speedups module as no-GILbfe7489Merge pull request #3492 from bdarnell/relnotes-6.5Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.
Summary by CodeRabbit